Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump ariadne and starlette versions #931

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Oct 28, 2024

Purpose/Motivation

Bumps starlette version from 0.36.2 -> 0.40.0 Changelog
Bumps ariadne from 0.19.1 -> 0.23.0 Changelog
Bumps ariadne-django from 0.2.0 -> 0.3.0 Changelog

None of these version bumps look to have any breaking changes, ran API locally and confirmed GQL requests are still coming in properly (Screenshot below)

The closest thing to breaking changes are removing support for Python 3.7, or removing some ariadne settings that we didn't use in the first place

Ariadne allows any version of starlette below version 1 -> https://github.com/mirumee/ariadne/blob/main/pyproject.toml

Links to relevant tickets

Closes https://github.com/codecov/internal-issues/issues/923

Screenshot 2024-10-28 at 12 10 05 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (cdebb02) to head (6fea982).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         823      823           
  Lines       18972    18972           
=======================================
  Hits        18257    18257           
  Misses        715      715           
Flag Coverage Δ
unit 92.47% <ø> (ø)
unit-latest-uploader 92.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit d984fa8 Oct 29, 2024
19 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/ariadne-starlette-bumps branch October 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants