Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove GQL playground access from prod #936

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Oct 29, 2024

Purpose/Motivation

What is the feature? Why is this being done?

Closes https://github.com/codecov/internal-issues/issues/916

Turning the setting off for SettingsModule.PRODUCTION.value and SettingsModule.ENTERPRISE.value

Tested locally by setting the line to get_settings_module() != SettingsModule.DEV.value and tried accessing at http://localhost:8000/graphql/ and the page was inaccessible.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (d984fa8) to head (d9fb01b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         823      823           
  Lines       18972    18972           
=======================================
  Hits        18257    18257           
  Misses        715      715           
Flag Coverage Δ
unit 92.47% <100.00%> (ø)
unit-latest-uploader 92.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@calvin-codecov calvin-codecov force-pushed the cy/no_prod_gql_playground branch from cc9366c to d9fb01b Compare October 29, 2024 18:49
@calvin-codecov calvin-codecov added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 142a003 Oct 29, 2024
19 checks passed
@calvin-codecov calvin-codecov deleted the cy/no_prod_gql_playground branch October 29, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants