Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Race condition in subscription creation webhook handlers #959

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Nov 4, 2024

Fixes weird bug in subscription creation webhook flow that caused customer's default payment method to not be set.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review November 4, 2024 20:42
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (97f26ab) to head (b860cfd).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #959   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         826      826           
  Lines       19040    19043    +3     
=======================================
+ Hits        18326    18329    +3     
  Misses        714      714           
Flag Coverage Δ
unit 92.50% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dank

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 5495e13 Nov 4, 2024
18 of 19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-subscription-creation branch November 4, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants