fix: correctly generate network if path has spaces #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing of output of the `ls-files` commands was splitting paths with spaces.
It is literally the difference show below.
```python
>>> s = 'string space\nother line\n'
>>> s.split()
['string', 'space', 'other', 'line']
>>> s.split('\n')
['string space', 'other line', '']
```
closes: #356
giovanni-guidini
requested review from
adrian-codecov,
joseph-sentry and
matt-codecov
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 80 80
Lines 2746 2746
=======================================
Hits 2623 2623
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing of output of the
ls-filescommands was splitting paths with spaces. It is literally the difference show below.closes: #356