build: don't run steps that req secrets if fork #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 81 81
Lines 2788 2788
=======================================
Hits 2675 2675
Misses 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
trent-codecov
previously approved these changes
Jan 25, 2024
joseph-sentry
force-pushed
the
joseph/update-ci-fork
branch
from
9c42562
to
d0e43bb
Compare
joseph-sentry
force-pushed
the
joseph/update-ci-fork
branch
2 times, most recently
from
6fa1e2e
to
661bbaf
Compare
we don't want to run the steps in the CI workflow that require access to secrets so that they don't block the tests from running. Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/update-ci-fork
branch
from
661bbaf
to
fa12604
Compare
trent-codecov
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't want to run the steps in the CI workflow that require access to secrets so that they don't block the tests from running.