Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove token check for report #461

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix: remove token check for report #461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
652f58c
fix: remove token check for report
thomasrockhu-codecov Jun 21, 2024
a40e072
fix: use the entire blip
thomasrockhu-codecov Jun 21, 2024
95d25d4
fix: don't try tokenless in create report results
joseph-sentry Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codecov_cli/services/report/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from codecov_cli.helpers.config import CODECOV_API_URL
from codecov_cli.helpers.encoder import decode_slug, encode_slug
from codecov_cli.helpers.request import (
get_token_header,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should still keep get_token_header_or_fail here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your comment is conflicting with the code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was an old version of the PR where get_token_header_or_fail was being deleted, i meant that we should keep both

get_token_header_or_fail,
log_warnings_and_errors_if_any,
request_result,
Expand Down Expand Up @@ -46,7 +47,7 @@ def send_create_report_request(
commit_sha, code, service, token, encoded_slug, enterprise_url, pull_request_number
):
data = {"code": code}
headers = get_token_header_or_fail(token)
headers = get_token_header(token)
upload_url = enterprise_url or CODECOV_API_URL
url = f"{upload_url}/upload/{service}/{encoded_slug}/commits/{commit_sha}/reports"
return send_post_request(url=url, headers=headers, data=data)
Expand Down
Loading