chore: consistent naming of upload options #473

giovanni-guidini · 2024-07-15T00:09:00Z

Makes the --report-code of do-upload to also accept
--code. This makes it consistent with other commands.

closes codecov/feedback#380

github-actions · 2024-07-15T00:09:35Z

❌ Failed Test Results:

Completed 692 tests with 2 failed, 690 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Testsuite:
tests.commands.test_invoke_upload_process::test_upload_process_options

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7f860a7a2ee0&gt;

    def test_upload_process_options(mocker):
        runner = CliRunner()
        fake_ci_provider = FakeProvider({FallbackFieldEnum.commit_sha: None})
        mocker.patch(&quot;codecov_cli.main.get_ci_adapter&quot;, return_value=fake_ci_provider)
        with runner.isolated_filesystem():
            runner = CliRunner()
            result = runner.invoke(cli, [&quot;upload-process&quot;, &quot;-h&quot;], obj={})
            assert result.exit_code == 0
            print(result.output)
    
&gt;           assert result.output.split(&quot;\n&quot;)[1:] == [
                &quot;Usage: cli upload-process [OPTIONS]&quot;,
                &quot;&quot;,
                &quot;Options:&quot;,
                &quot;  -C, --sha, --commit-sha TEXT    Commit SHA (with 40 chars)  [required]&quot;,
                &quot;  -Z, --fail-on-error             Exit with non-zero code in case of error&quot;,
                &quot;  --git-service [github

github-actions · 2024-07-15T00:09:36Z

❌ Failed Test Results:

Completed 692 tests with 2 failed, 690 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
tests.commands.test_invoke_upload_process::test_upload_process_options

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7fcd8175b0a0&gt;

    def test_upload_process_options(mocker):
        runner = CliRunner()
        fake_ci_provider = FakeProvider({FallbackFieldEnum.commit_sha: None})
        mocker.patch(&quot;codecov_cli.main.get_ci_adapter&quot;, return_value=fake_ci_provider)
        with runner.isolated_filesystem():
            runner = CliRunner()
            result = runner.invoke(cli, [&quot;upload-process&quot;, &quot;-h&quot;], obj={})
            assert result.exit_code == 0
            print(result.output)
    
&gt;           assert result.output.split(&quot;\n&quot;)[1:] == [
                &quot;Usage: cli upload-process [OPTIONS]&quot;,
                &quot;&quot;,
                &quot;Options:&quot;,
                &quot;  -C, --sha, --commit-sha TEXT    Commit SHA (with 40 chars)  [required]&quot;,
                &quot;  -Z, --fail-on-error             Exit with non-zero code in case of error&quot;,
                &quot;  --git-service [github

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T00:09:36Z

❌ Failed Test Results:

Completed 692 tests with 2 failed, 690 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
tests.commands.test_invoke_upload_process::test_upload_process_options

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7f5a129635d0&gt;

    def test_upload_process_options(mocker):
        runner = CliRunner()
        fake_ci_provider = FakeProvider({FallbackFieldEnum.commit_sha: None})
        mocker.patch(&quot;codecov_cli.main.get_ci_adapter&quot;, return_value=fake_ci_provider)
        with runner.isolated_filesystem():
            runner = CliRunner()
            result = runner.invoke(cli, [&quot;upload-process&quot;, &quot;-h&quot;], obj={})
            assert result.exit_code == 0
            print(result.output)
    
&gt;           assert result.output.split(&quot;\n&quot;)[1:] == [
                &quot;Usage: cli upload-process [OPTIONS]&quot;,
                &quot;&quot;,
                &quot;Options:&quot;,
                &quot;  -C, --sha, --commit-sha TEXT    Commit SHA (with 40 chars)  [required]&quot;,
                &quot;  -Z, --fail-on-error             Exit with non-zero code in case of error&quot;,
                &quot;  --git-service [github

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T00:09:37Z

❌ Failed Test Results:

Completed 692 tests with 2 failed, 690 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Testsuite:
tests.commands.test_invoke_upload_process::test_upload_process_options

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7f08d9026140&gt;

    def test_upload_process_options(mocker):
        runner = CliRunner()
        fake_ci_provider = FakeProvider({FallbackFieldEnum.commit_sha: None})
        mocker.patch(&quot;codecov_cli.main.get_ci_adapter&quot;, return_value=fake_ci_provider)
        with runner.isolated_filesystem():
            runner = CliRunner()
            result = runner.invoke(cli, [&quot;upload-process&quot;, &quot;-h&quot;], obj={})
            assert result.exit_code == 0
            print(result.output)
    
&gt;           assert result.output.split(&quot;\n&quot;)[1:] == [
                &quot;Usage: cli upload-process [OPTIONS]&quot;,
                &quot;&quot;,
                &quot;Options:&quot;,
                &quot;  -C, --sha, --commit-sha TEXT    Commit SHA (with 40 chars)  [required]&quot;,
                &quot;  -Z, --fail-on-error             Exit with non-zero code in case of error&quot;,
                &quot;  --git-service [github

github-actions · 2024-07-15T00:09:59Z

❌ Failed Test Results:

Completed 692 tests with 2 failed, 690 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
tests.commands.test_invoke_upload_process::test_upload_process_options

Test name:
pytest

mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7f29c6c86690&gt;

    def test_upload_process_options(mocker):
        runner = CliRunner()
        fake_ci_provider = FakeProvider({FallbackFieldEnum.commit_sha: None})
        mocker.patch(&quot;codecov_cli.main.get_ci_adapter&quot;, return_value=fake_ci_provider)
        with runner.isolated_filesystem():
            runner = CliRunner()
            result = runner.invoke(cli, [&quot;upload-process&quot;, &quot;-h&quot;], obj={})
            assert result.exit_code == 0
            print(result.output)
    
&gt;           assert result.output.split(&quot;\n&quot;)[1:] == [
                &quot;Usage: cli upload-process [OPTIONS]&quot;,
                &quot;&quot;,
                &quot;Options:&quot;,
                &quot;  -C, --sha, --commit-sha TEXT    Commit SHA (with 40 chars)  [required]&quot;,
                &quot;  -Z, --fail-on-error             Exit with non-zero code in case of error&quot;,
                &quot;  --git-service [github

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Makes the `--report-code` of `do-upload` to also accept `--code`. This makes it consistent with other commands. closes codecov/feedback#380

github-actions · 2024-07-15T00:13:24Z

❌ Failed Test Results:

Completed 692 tests with 1 failed, 691 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T00:13:26Z

❌ Failed Test Results:

Completed 692 tests with 1 failed, 691 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T00:13:30Z

❌ Failed Test Results:

Completed 692 tests with 1 failed, 691 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

codecov · 2024-07-15T00:13:34Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 3465 tests with 5 failed, 3460 passed and 0 skipped.

View the full list of failed tests

pytest

Class name: api.temp.calculator.test_calculator
Test name: test_divide
Flags:

python3.12

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Class name: api.temp.calculator.test_calculator
Test name: test_divide
Flags:

python3.8

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Class name: api.temp.calculator.test_calculator
Test name: test_divide
Flags:

python3.11

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Class name: api.temp.calculator.test_calculator
Test name: test_divide
Flags:

python3.10

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

Class name: api.temp.calculator.test_calculator
Test name: test_divide
Flags:

python3.9

def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T00:13:44Z

❌ Failed Test Results:

Completed 692 tests with 1 failed, 691 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-15T00:13:44Z

❌ Failed Test Results:

Completed 692 tests with 1 failed, 691 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T11:37:55Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T11:37:59Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T11:38:00Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T11:38:05Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T11:38:11Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:32:26Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:32:28Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:32:36Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:32:37Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:32:46Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:47:00Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:47:05Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:47:06Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:47:31Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-07-17T12:47:33Z

❌ Failed Test Results:

Completed 693 tests with 1 failed, 692 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

webknjaz · 2024-08-27T16:09:07Z

.github/workflows/build_assets.yml

@@ -31,8 +31,7 @@ jobs:
          - os: ubuntu-20.04
            TARGET: ubuntu
            CMD_REQS: >
-              pip install -r requirements.txt
-              pip install .
+              pip install -r requirements.txt && pip install .


@giovanni-guidini FYI, both deps could be passed to the same pip install command. There's no technical reason for running it twice here.

chore: consistent naming of upload options

a513878

Makes the `--report-code` of `do-upload` to also accept `--code`. This makes it consistent with other commands. closes codecov/feedback#380

giovanni-guidini force-pushed the gio/feedback-380 branch from bda9e20 to a513878 Compare July 15, 2024 00:12

giovanni-guidini requested review from joseph-sentry and a team and removed request for joseph-sentry July 15, 2024 00:19

Swatinem previously approved these changes Jul 17, 2024

View reviewed changes

Merge branch 'main' into gio/feedback-380

3bc7f4c

giovanni-guidini dismissed Swatinem’s stale review via de2470b July 17, 2024 12:31

attempt to fix build that is broken for some reason

3a859ac

giovanni-guidini force-pushed the gio/feedback-380 branch from de2470b to 3a859ac Compare July 17, 2024 12:46

giovanni-guidini requested a review from Swatinem July 17, 2024 13:37

Swatinem approved these changes Jul 17, 2024

View reviewed changes

giovanni-guidini merged commit f509528 into main Jul 17, 2024
22 checks passed

giovanni-guidini deleted the gio/feedback-380 branch July 17, 2024 15:27

webknjaz reviewed Aug 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: consistent naming of upload options #473

chore: consistent naming of upload options #473

giovanni-guidini commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

codecov bot commented Jul 15, 2024 •

edited

Loading

pytest

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 17, 2024

webknjaz Aug 27, 2024

chore: consistent naming of upload options #473

chore: consistent naming of upload options #473

Conversation

giovanni-guidini commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

codecov bot commented Jul 15, 2024 • edited Loading

❌ Failed Test Results:

pytest

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 15, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

github-actions bot commented Jul 17, 2024

❌ Failed Test Results:

webknjaz Aug 27, 2024

Choose a reason for hiding this comment

codecov bot commented Jul 15, 2024 •

edited

Loading