-
Notifications
You must be signed in to change notification settings - Fork 21
Slug generation is incorrect when using username and password in url. #79
Comments
How are you calling codecov-exe? What arguments to you set? |
I'm using codecov.exe on windows 10 from cmd. Here is my command:
|
@aelassas and do the commit you are running on exist in a remote git repository? If the commit do exist in the remote repository, then I would need to get together a new build with some additional logging enabled to get the response body from the server (sometimes it contains clues to why it returns a bad request message). |
@AdmiringWorm Yes the commit I am running do exist in the remote git repository. I'm using codecov.exe 1.6.1 (the latest) for Windows. I downloaded it from nuget.org. |
@aelassas I have created an edition with logging of the returned value from the server being outputted (only if the returned type is plain text). Would you mind testing it out to see what gets reported by the server? |
@AdmiringWorm I have tested the version 1.7.0 with extra logging but the problem remains. Here is the output:
I am using codecov-windows-x64.exe from a command line in Windows 10 x64. And below is the command I am using:
And I also tested the following command:
|
hmm, looks like there is a problem with the generation of the slug (so this fails the validation upstream). Try specifying it manually with the |
Just trying to figure out why it gets the wrong url. That command is what we are using to generate the slug. |
I am almost certain that you maybe have a trailing slash on the outputted url, or it contains a slash right after a second one. But want to make sure that is the problem before figuring out a fix. |
With --slug aelassas/Wexflow option, it works fine. Here is the result of the command git config --get remote.origin.url:
|
Thank you, I have figured out why it is failing now. |
* feature/extra-logging: (GH-79) Fixed slug generation from git remote url (GH-79) Added unit tests for incorrectly parsed git url (maint) Extracted code regarding upload failure reporting to own method (GH-78) Added loggingi of result body in fallback uploader if it is plain text (GH-78) Added loggingi of result body if it is plain text
* release/1.7.0: (build) Updated package dependencies for unit testing library (GH-79) Fixed slug generation from git remote url (GH-79) Added unit tests for incorrectly parsed git url (maint) Extracted code regarding upload failure reporting to own method (GH-78) Added loggingi of result body in fallback uploader if it is plain text (GH-78) Added loggingi of result body if it is plain text (GH-77) Changed to publish to nuget and github through Ubuntu
🎉 This issue has been resolved in version 1.7.0 🎉 The release is available on:
|
When I try to upload with this new version using the command:
I get the following error;
But when I try to upload using --slug:
It succeeds after an error:
|
@aelassas would you mind opening a new issue for this, although it seems to be related I do believe this is something else entirely. |
@AdmiringWorm done. |
Thank you. |
Hi,
When I try to upload my report I get the following error:
Can you please helpe me so I can upload my reports to codecov.io?
Kind regrads,
Akram.
The text was updated successfully, but these errors were encountered: