Add glob pattern support to -f parameter #69
Conversation
|
Not sure why there's no appveyor ci build for this PR but I have one here: |
| public void CoverageReport_Should_Be_Empty_If_The_File_Does_Not_Exits(string fileData) | ||
| { | ||
| // Given | ||
| var options = Substitute.For<ICoverageOptions>(); | ||
| ICoverageOptions options = Substitute.For<ICoverageOptions>(); |
There was a problem hiding this comment.
please don't change the existing style used in the library
There was a problem hiding this comment.
It was new vs2019 code formatter :)
There was a problem hiding this comment.
Ah, I see.
Is there any configuration file that can be added to the repository that overrides the these style settings? I'm working in Linux, so I don't use Visual Studio 2019 unfortunately.
| @@ -21,15 +22,45 @@ public Coverage(ICoverageOptions coverageOptions) | |||
|
|
|||
| private ICoverageOptions CoverageOptions { get; } | |||
|
|
|||
| private static bool VerifyReportFile(string path) | |||
| private static bool VerifyReportFile(string path, out IEnumerable<string> expandedPath) | |||
There was a problem hiding this comment.
Not sure if I agree with using an out parameter here.
The method should only verify the files, not actually get the files.
There was a problem hiding this comment.
How about giving it a different name?
There was a problem hiding this comment.
I was thinking more of separating the globbing logic into a different method that would handle the expanding of the correct file that will be matched.
But I can look into this at a later time.
|
Your changes have been merged, thank you for your contribution 😃 |
* release/1.6.0: (maint) Fixed additional issues detected by InspectCode (maint) Fixed stylecop issues + updated editorconfig file with vs settings (maint) Ran codemaid cleanup + Re-Organizer (GH-67) Changed codecov nuget package to include the compiled warp binaries (GH-66) Update build file to create self-contained application using warp (GH-38) Implement ability to fall back to v2 url (GH-38) Add fallback values to Route and url (build) Remove verbose logging during ci builds (maint) Change uploaders to use the new CodecovUploader class (GH-70) Chang WebClient uploader to use HttpClient (maint) Remove HttpWebRequest uploader (maint) Add helper method to get rid of duplicated code lines (maint) Corrected variable name for travis detection (build) add coverlet and customized codecov tasks support (build) add travis build script (GH-65) Add implementation of Travis CI detector (GH-65) Add unit tests for implementation of Travis CI detector (GH-52) change exit code to 160 when invalid arguments is used Add glob pattern support to -f parameter (#69)
#68