Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "impacted files" copy from <details> element #2136

Open
Tracked by #1028
codecovdesign opened this issue Jul 23, 2024 · 0 comments
Open
Tracked by #1028

Remove "impacted files" copy from <details> element #2136

codecovdesign opened this issue Jul 23, 2024 · 0 comments
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling.

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jul 23, 2024

Problem to solve

In the details section of PR comment "Impacted files" can cause confusion - consider cases when all changed files are covered, or alternative like this scenario below when some files are missing coverage, user may thing the "impacted.." in details may be more files and/or that it's separate from what we show which is actually changed files.

Image

Solution

  • remove "impacted files" from <details>
@codecovdesign codecovdesign added the Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling.
Projects
None yet
Development

No branches or pull requests

1 participant