Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: pull request configuration, yaml, and debt #1028

Open
8 of 29 tasks
codecovdesign opened this issue Jan 9, 2024 · 4 comments
Open
8 of 29 tasks

Discovery: pull request configuration, yaml, and debt #1028

codecovdesign opened this issue Jan 9, 2024 · 4 comments
Assignees
Labels
epic this label is used to mark issues as epics in discovery The design, product, and specifications require refinement

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jan 9, 2024

TLDR? previously, in phase I of this epic we did some housekeeping to understand our issues better, identify yaml cleanups, and ensure that our intended displays of pr comment formats was displaying as intended across the different plans and settings (in case of deprecated yaml inputs). Next we are looking to 1) understand and better identify default yaml, 2) identify out of the box yaml configs, 3) understand and identify yam usage data, 4) ideation of longer terms yaml builder/helper in UI

Problems to solve, discovery phase II

  • What is the systems default yaml?

    • Once identified: identify improvement/cleanups/deprecations/etc AND audit existing UI notification showing default yaml (next steps)
  • What is the current yaml usage?

    • such as: custom vs yaml, pro vs team vs free
    • what are the most common settings / what are the least common settings
    • flags usage, how many CFF, components
    • what are next steps? (deprecation, docs improvements)
    • explore qualitative feedback, such as: Proper yaml setup to skip files in coverage testing feedback#493 to identify trends and common challenges
  • What do our input mean/translate to?

    • Translate existing inputs from docs into more clear outcomes if used
    • audit inputs and rewrite/coordinate to what would happen
  • What could longer term yaml building look like?

discovery phase I: housekeeping ## Problem to solve

The pull request comment formatting and options have changed through different iterations over time. Along the way, some yaml settings are now duplicative and/or unknown internally and/or outdated. This discovery is aimed at documenting the issues and customer feedback and doing some housekeeping:

Solution ideation

  • Audit the yaml/configuration states
  • Revisit the yaml in-app discovery
    • Ideate on follow up iterations
  • Identify ux/eng debt to address

WIP: view main figma file

Tasks

Preview Give feedback
  1. in discovery
    Adal3n3 codecovdesign
  2. Dev-Ready Polish
    joseph-sentry
  3. in discovery
    codecovdesign
  4. in discovery
    codecovdesign joseph-sentry
  5. Dev-Ready bug
    joseph-sentry
  6. Dev-Ready
  7. Dev-Ready P0: must do
    codecovdesign
  8. 3 of 4
    Dev-Ready
    Adal3n3
  9. Dev-Ready
    joseph-sentry
  10. Dev-Ready Polish
    joseph-sentry
  11. in discovery
  12. Dev-Ready
    joseph-sentry
  13. Dev-Ready
    codecovdesign
  14. in discovery
    Adal3n3 codecovdesign
  15. 6 of 6
    epic in discovery
    giovanni-guidini
  16. in discovery
  17. Dev-Ready bug
    joseph-sentry
  18. Dev-Ready
  19. in discovery
  20. in discovery
    codecovdesign
  21. Dev-Ready in discovery
    nora-codecov
  22. in discovery
    Adal3n3
  23. in discovery
  24. Low bug
  25. in discovery investigation
    JerrySentry
  26. in discovery
@codecovdesign codecovdesign added the in discovery The design, product, and specifications require refinement label Jan 9, 2024
@codecovdesign codecovdesign self-assigned this Jan 9, 2024
@codecovdesign
Copy link
Contributor Author

codecovdesign commented Sep 9, 2024

sync on sept 9th, default yaml kickoff:

What is the systems default yaml? Once identified: identify improvement/cleanups/deprecations/etc AND audit existing UI notification showing default yaml (next steps)

@codecovdesign
Copy link
Contributor Author

checkin on sept 17th

  • default yaml parts, so far
  • will need to con't investigation of read only areas
  • null is seen as a placeholders that are worth investigating more
  • there could be different default based on where in the code you are, depending on what you are doing
  • first step continues to be documenting the yaml file
  • kyle ToDo design turn for default yaml

@codecovdesign
Copy link
Contributor Author

checkin on oct 1

  • updated the notion doc for the default yaml with a paste of all the places where read_yaml_field is called in the worker (this might not be totally accurate)
    • consideration around refactoring, since this may not be optimal
  • not sure how the yaml is being used in the API
  • two things to consider separatly 1) product related issues, 2) eng work
    • with product it's what are the implications of default ux given the yaml
    • with eng work it's about what is the default yaml
  • ToDo add commit yaml issues if relevant
  • ToDo kyle to create slack channel

@codecovdesign codecovdesign added the epic this label is used to mark issues as epics label Oct 22, 2024
@codecovdesign
Copy link
Contributor Author

codecovdesign commented Oct 22, 2024

working session:

  • created agenda doc
  • what is the process of the system evaluating the yaml values
    • what is the mechanism to which/what makes up the yaml (sources)
    • of the different yamls, which one is evaluated as the priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic this label is used to mark issues as epics in discovery The design, product, and specifications require refinement
Projects
None yet
Development

No branches or pull requests

1 participant