Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files table header #2237

Closed
Tracked by #1028
codecovdesign opened this issue Aug 9, 2024 · 2 comments
Closed
Tracked by #1028

Update files table header #2237

codecovdesign opened this issue Aug 9, 2024 · 2 comments
Assignees
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. in discovery The design, product, and specifications require refinement

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Aug 9, 2024

Problem to solve

The table in the PR comment that is displayed shows only in the case there are files changed that have reduced coverage. This is not explicit with the current labeling.

Image

Solution

Updated table's File table header to Files with missing lines

@codecovdesign codecovdesign added in discovery The design, product, and specifications require refinement Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. labels Aug 9, 2024
@nora-codecov
Copy link

some feedback from a codecov connoisseur (@giovanni-guidini), this wording might not be a good substitute. He recommends Files with missing lines instead, what do we think of this @codecovdesign ?

link to Gio's full comment

@codecovdesign
Copy link
Contributor Author

recommends Files with missing lines

@nora-codecov @giovanni-guidini love it! updated the description accordingly

@codecov-hooky codecov-hooky bot closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. in discovery The design, product, and specifications require refinement
Projects
None yet
Development

No branches or pull requests

2 participants