Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to see overall patch % for PR changes #986

Closed
Tracked by #1028
codecovdesign opened this issue Jan 4, 2024 · 0 comments
Closed
Tracked by #1028

Unable to see overall patch % for PR changes #986

codecovdesign opened this issue Jan 4, 2024 · 0 comments
Assignees
@joseph-sentry
Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jan 4, 2024 •
edited
Loading

Problem to solve

With recent changes to the PR comment, one result is removal of ability to see patch % (new shows only volume count of missed lines). Received some feedback about this: codecov/feedback#203

Current, if missing lines:

Attention: 4 lines in your changes are missing coverage. Please review.

Solution

Update copy to include patch:

Attention: patch coverage is 75% with 3 lines in your changes missing coverage. Please review.

WIP: view designs
@codecovdesign codecovdesign added the in discovery The design, product, and specifications require refinement label Jan 4, 2024
@codecovdesign codecovdesign self-assigned this Jan 4, 2024
@codecovdesign codecovdesign changed the title Unable to see patch % Unable to see patch % for PR changes Jan 4, 2024
@codecovdesign codecovdesign changed the title Unable to see patch % for PR changes Unable to see overall patch % for PR changes Jan 4, 2024
@codecovdesign codecovdesign mentioned this issue Jan 9, 2024
Open
@codecovdesign codecovdesign added Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics and removed in discovery The design, product, and specifications require refinement labels Jan 22, 2024
@codecovdesign codecovdesign removed their assignment Jan 31, 2024
@joseph-sentry joseph-sentry mentioned this issue Feb 15, 2024
Merged
@codecov-hooky codecov-hooky bot closed this as completed Feb 29, 2024
@codecov-hooky codecov-hooky bot closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joseph-sentry joseph-sentry

Labels
Dev-Ready This means the UX is reviewed and ready for prioritization scheduling. Polish polish, tweaks, and bug issues that are small iterations and/or not part of larger quarterly epics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codecovdesign @joseph-sentry