Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tokens_required field for owners table #2297

Closed
Tracked by #826
trent-codecov opened this issue Aug 15, 2024 · 2 comments
Closed
Tracked by #826

Add new tokens_required field for owners table #2297

trent-codecov opened this issue Aug 15, 2024 · 2 comments
Assignees
Labels
database Includes a database migration

Comments

@trent-codecov
Copy link
Contributor

We need a new default true field for owners (maybe accounts?) to indicate whether tokens are required at all for public repos. tokens_required or similar.

@nora-codecov
Copy link

How about upload_token_required_for_public_repos?

Not going to add to Account, I want this to be set per org. Owner table still holds other permission-related fields so I feel like it fits best there. We can add to Account later if need arises.

Wouldn't the default be False?

I'm going to add this as a nullable boolean field with default = False, then backfill all existing orgs to True, then make it non-nullable 👍

@nora-codecov
Copy link

I did end up adding this column as default=True because I realized this will act sort of like a feature flag, and should remain True for everyone until we are ready for it to go live.

I'll add a task to this epic to flip the default to False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Includes a database migration
Projects
None yet
Development

No branches or pull requests

2 participants