-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add upload_token_required_for_public_repos, backfill and make non-nullable #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
So this will create the column as NULL
, the backfill sets that to true
, and then later on the NULL
is removed, and the default false
remains?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 89.74% 89.11% -0.64%
==========================================
Files 380 324 -56
Lines 11736 9694 -2042
Branches 2071 1737 -334
==========================================
- Hits 10533 8639 -1894
+ Misses 1114 991 -123
+ Partials 89 64 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f81584d
to
9d6b0e9
Compare
66d5c31
to
46eb99f
Compare
46eb99f
to
fae2468
Compare
codecov/engineering-team#2297