Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upload_token_required_for_public_repos, backfill and make non-nullable #373

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

nora-codecov
Copy link
Contributor

@nora-codecov nora-codecov requested a review from a team September 27, 2024 21:34
Swatinem
Swatinem previously approved these changes Sep 30, 2024
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
So this will create the column as NULL, the backfill sets that to true, and then later on the NULL is removed, and the default false remains?

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (a97eb0a) to head (fc0b7f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   89.74%   89.11%   -0.64%     
==========================================
  Files         380      324      -56     
  Lines       11736     9694    -2042     
  Branches     2071     1737     -334     
==========================================
- Hits        10533     8639    -1894     
+ Misses       1114      991     -123     
+ Partials       89       64      -25     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nora-codecov nora-codecov force-pushed the nora/2297 branch 2 times, most recently from f81584d to 9d6b0e9 Compare October 1, 2024 01:05
@nora-codecov nora-codecov force-pushed the nora/2297 branch 4 times, most recently from 66d5c31 to 46eb99f Compare October 2, 2024 00:16
@nora-codecov nora-codecov added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 88117b9 Oct 3, 2024
6 checks passed
@nora-codecov nora-codecov deleted the nora/2297 branch October 3, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants