-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing required non-NULL Owner
column
#757
Conversation
A recent migration has added the `upload_token_required_for_public_repos` column to `Owner`, which was not updated properly in the `worker` code, and inserts to that table are now failing because of a missing default.
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36285 36286 +1
=======================================
+ Hits 35569 35570 +1
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36285 36286 +1
=======================================
+ Hits 35569 35570 +1
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36285 36286 +1
=======================================
+ Hits 35569 35570 +1
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36285 36286 +1
=======================================
+ Hits 35569 35570 +1
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
A recent migration has added the
upload_token_required_for_public_repos
column toOwner
, which was not updated properly in theworker
code, and inserts to that table are now failing because of a missing default.This does the same as codecov/shared#373 for the
sqlalchemy
based models.