Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing required non-NULL Owner column #757

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Oct 3, 2024

A recent migration has added the upload_token_required_for_public_repos column to Owner, which was not updated properly in the worker code, and inserts to that table are now failing because of a missing default.

This does the same as codecov/shared#373 for the sqlalchemy based models.

A recent migration has added the `upload_token_required_for_public_repos` column to `Owner`, which was not updated properly in the `worker` code, and inserts to that table are now failing because of a missing default.
@Swatinem Swatinem requested a review from a team October 3, 2024 08:28
@Swatinem Swatinem self-assigned this Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

This PR includes changes to shared. Please review them here: codecov/shared@36791fe...88117b9

@Swatinem Swatinem enabled auto-merge October 3, 2024 08:34
@codecov-notifications
Copy link

codecov-notifications bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36285    36286    +1     
=======================================
+ Hits        35569    35570    +1     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (c2bfdcf) to head (17c7702).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36285    36286    +1     
=======================================
+ Hits        35569    35570    +1     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️

@Swatinem Swatinem added this pull request to the merge queue Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (c2bfdcf) to head (17c7702).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36285    36286    +1     
=======================================
+ Hits        35569    35570    +1     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (c2bfdcf) to head (17c7702).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36285    36286    +1     
=======================================
+ Hits        35569    35570    +1     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.87% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️

Merged via the queue into main with commit 18aed4e Oct 3, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/fix-tokens branch October 3, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants