-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new field email_opt_in to user model #377
Conversation
5dc3404
to
bf3b6ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 90.30% 89.88% -0.42%
==========================================
Files 381 324 -57
Lines 11660 9605 -2055
Branches 2051 1716 -335
==========================================
- Hits 10529 8633 -1896
+ Misses 1042 908 -134
+ Partials 89 64 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
518f592
to
eeffa10
Compare
2f9fcfc
to
85bea9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last question - should this be a risky migration? I'm not sure how big this table is.
make sure you don't make the same mistake I did, where I put api and worker's representation of the table out of sync 🙃
arpad fixed it here codecov/worker#757
(the default value lives in django, so worker's sqlalchemy and the database's psql don't know what the default should be, so they try to use null and get an error because the field is not nullable)
i think we don't usually mark user related fields as risky, thank you for the heads up! |
This is needed for marketing reasons.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.