Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] - Add Logic to ImpactedFiles Filtering by Flag to Indicate Proper States #641

Closed
Tracked by #217
nicholas-codecov opened this issue Oct 4, 2023 · 1 comment
Assignees

Comments

@nicholas-codecov
Copy link

nicholas-codecov commented Oct 4, 2023

We recently added the functionality to filter impacted files by flags, but didn't catch all the scenarios. We want to catch the scenario when a flag doesn't belong to the list of flags you can filter by similar to how we do it here https://github.com/codecov/codecov-api/blob/main/graphql_api/types/commit/commit.py#L176.

This might need a bit of refactoring of the impactedFiles resolver, as we currently don't return a custom ImpactedFiles type along different errors the way pathContents does. For this change, we'll likely want to:

@adrian-codecov adrian-codecov changed the title [API] - ImpactedFilesFilters Argument Not Filtering out Files [API] - Add Logic to ImpactedFiles Filtering by Flag to Indicate Proper States Oct 4, 2023
@JerrySentry
Copy link

JerrySentry commented Oct 11, 2023

impactedFiles(filters: $filters) {
__typename
... on ImpactedFiles {
results {
# [ImpactedFile]
}
}
... on UnknownFlags {
message
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants