You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might need a bit of refactoring of the impactedFiles resolver, as we currently don't return a custom ImpactedFiles type along different errors the way pathContents does. For this change, we'll likely want to:
adrian-codecov
changed the title
[API] - ImpactedFilesFilters Argument Not Filtering out Files
[API] - Add Logic to ImpactedFiles Filtering by Flag to Indicate Proper States
Oct 4, 2023
We recently added the functionality to filter impacted files by flags, but didn't catch all the scenarios. We want to catch the scenario when a flag doesn't belong to the list of flags you can filter by similar to how we do it here https://github.com/codecov/codecov-api/blob/main/graphql_api/types/commit/commit.py#L176.
This might need a bit of refactoring of the impactedFiles resolver, as we currently don't return a custom ImpactedFiles type along different errors the way
pathContents
does. For this change, we'll likely want to:ImpactedFiles
andUnknownFlags
resultUnknownFlags
exception early onimpactedFilesTemp
or something along the lines, so the frontend doesn't break with these changesThe text was updated successfully, but these errors were encountered: