feat: add new resolver for impacted files #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
=====================================
Coverage 95.52 95.52
=====================================
Files 714 714
Lines 15615 15608 -7
=====================================
- Hits 14915 14908 -7
Misses 700 700
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 95.62% 95.61% -0.01%
==========================================
Files 600 600
Lines 15209 15202 -7
==========================================
- Hits 14543 14536 -7
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 95.62% 95.61% -0.01%
==========================================
Files 600 600
Lines 15209 15202 -7
==========================================
- Hits 14543 14536 -7
Misses 666 666
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adrian-codecov
approved these changes
Oct 13, 2023
JerrySentry
added a commit
that referenced
this pull request
Oct 13, 2023
This reverts commit adc3e6c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
What is the feature? Why is this being done?
Have ImpactedFiles do what ImpactedFilesNew used to do, and remove the "..New" one
Links to relevant tickets
codecov/engineering-team#641
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.