Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pull specific flags in pull request page flags selector #823

Closed
Tracked by #828
RulaKhaled opened this issue Nov 20, 2023 · 0 comments · Fixed by codecov/gazebo#2531
Closed
Tracked by #828

Show pull specific flags in pull request page flags selector #823

RulaKhaled opened this issue Nov 20, 2023 · 0 comments · Fixed by codecov/gazebo#2531
Assignees

Comments

@RulaKhaled
Copy link

Problem: It is confusing to be able to filter pull flags tab using flags that don’t belong to the PR, we're sending pointless requests to the backend where we can limit the calls to send only useful requests that we can actually make use of flags filter in.

Solution: Show PR specific flags in the pull request page flags selector

we can either use whatever flags tab is using or add a filter API to accept a pullid and adjust current hook to pass it

you will need to create a separate API issue if you decide to move forward with 2nd option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants