[feat] Allow search by term for flag comparisons #350
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
+ Coverage 95.70 95.71 +0.01
=======================================
Files 740 740
Lines 16716 16720 +4
=======================================
+ Hits 15998 16002 +4
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 625 625
Lines 16200 16204 +4
=======================================
+ Hits 15561 15565 +4
Misses 639 639
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 625 625
Lines 16200 16204 +4
=======================================
+ Hits 15561 15565 +4
Misses 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
rohitvinnakota-codecov
force-pushed
the
rvinnakota/update-flagset-filters
branch
from
e8c5bbd to
55c84e0
Compare
rohitvinnakota-codecov
changed the title
Purpose/Motivation
Related to codecov/engineering-team#823, this PR updates the flags comparison type to accept a filter that allows lookups by flag term. This is required in the front end to allow the search field in the flags selector to apply to the query.
Links to relevant tickets
This closes codecov/engineering-team#1064.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.