Adjust loginProvider events

codecov · Jan 28, 2025 · 48d8ced · 48d8ced
1 parent 62cf1f0
commit 48d8ced
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/src/pages/LoginPage/LoginButton.jsx b/src/pages/LoginPage/LoginButton.jsx
@@ -26,8 +26,9 @@ function LoginButton({ provider }) {
         eventTracker().track({
           type: 'Button Clicked',
           properties: {
-            buttonName: `Login with ${providerName}`,
+            buttonName: 'Login',
             buttonLocation: 'Login Page',
+            loginProvider: providerName,
           },
         })
       }}

diff --git a/src/pages/SyncProviderPage/SyncButton.tsx b/src/pages/SyncProviderPage/SyncButton.tsx
@@ -22,8 +22,9 @@ const SyncButton: React.FC<SyncButtonProps> = ({ provider }) => {
           eventTracker().track({
             type: 'Button Clicked',
             properties: {
-              buttonName: `Sync with ${providerName}`,
+              buttonName: 'Sync',
               buttonLocation: 'Sync Provider Page',
+              loginProvider: providerName,
             },
           })
         }}

diff --git a/src/services/events/types.ts b/src/services/events/types.ts
@@ -1,5 +1,5 @@
 import { Provider } from 'shared/api/helpers'
-import { providerToName } from 'shared/utils/provider'
+import { loginProviderToName } from 'shared/utils/loginProviders'
 
 //
 // Add new events to the the Event union type below!
@@ -30,6 +30,7 @@ export type Event =
       properties: {
         buttonName: ButtonName
         buttonLocation?: string
+        loginProvider?: ReturnType<typeof loginProviderToName> // for login buttons only
       }
     }
   | {
@@ -86,16 +87,12 @@ export abstract class EventTracker {
 // Extend as needed.
 //
 
-type ProviderName = ReturnType<typeof providerToName>
-type SyncButtonName = `Sync with ${ProviderName}`
-type LoginButtonName = `Login with ${ProviderName}`
-
 type ButtonName =
   | 'Install GitHub App'
   | 'Configure Repo'
   | 'Open App Install Modal'
   | 'Continue'
-  | SyncButtonName
-  | LoginButtonName
+  | 'Login'
+  | 'Sync'
 
 type PageName = 'Owner Page'