Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide Commits Page Team Files Changed Table for Public Repos #2364

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

nicholas-codecov
Copy link
Contributor

Description

Quickly updating the FilesChangedTableTeam for the commit detail page to only render the team table when the repo is private and the tier is team.

Notable Changes

  • Update FilesChangedTableTeam to check repo visibility
  • Update tests

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 9f4f34f
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65422d26e207cc0008d09790
😎 Deploy Preview https://deploy-preview-2364--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-qa
Copy link

codecov-qa bot commented Oct 31, 2023

Codecov Report

Merging #2364 (5f69127) into main (89e4ea3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5f69127 differs from pull request most recent head 9f4f34f. Consider uploading reports for the commit 9f4f34f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2364   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         727      725    -2     
  Lines        8706     8685   -21     
  Branches     2149     2102   -47     
=======================================
- Hits         8458     8438   -20     
+ Misses        246      245    -1     
  Partials        2        2           
Files Coverage Δ
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e4ea3...9f4f34f. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 31, 2023

Codecov Report

Merging #2364 (9f4f34f) into main (89e4ea3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2364   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         727      727           
  Lines        8706     8710    +4     
  Branches     2137     2158   +21     
=======================================
+ Hits         8458     8462    +4     
  Misses        245      245           
  Partials        3        3           
Files Coverage Δ
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e4ea3...9f4f34f. Read the comment docs.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2364 (9f4f34f) into main (89e4ea3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2364   +/-   ##
=====================================
  Coverage   97.15   97.15           
=====================================
  Files        727     727           
  Lines       8706    8710    +4     
  Branches    2104    2158   +54     
=====================================
+ Hits        8458    8462    +4     
+ Misses       246     245    -1     
- Partials       2       3    +1     
Files Coverage Δ
...lPage/subRoute/FilesChangedTab/FilesChangedTab.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e4ea3...9f4f34f. Read the comment docs.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholas-codecov nicholas-codecov merged commit 72cc111 into main Nov 1, 2023
28 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-619-hide-new-table-for-public-repos branch November 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants