Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop Transactions from Blocked User Agents #2372

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

nicholas-codecov
Copy link
Contributor

Description

Just some small tweaks to our Sentry config to clean up our issues as well as stopping the use of deprecated options.

Notable Changes

  • Create function to check for blocked user agents
  • Set Sentry Replay rates

@@ -51,6 +51,14 @@ const deClutterConfig = {

export const SentryRoute = Sentry.withSentryRouting(Route)

const checkForBlockedUserAgents = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny! When I first reviewed this I was going to suggest doing an approach like this to add a list of agents we wanted blocked, but then I thought it was a bit overkill, so funny we arrived to this on our own

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it out cause we're using it in two locations now ... so I thought it best they stay in sync with one another

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 6d8bc4e
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6543c536bfa8eb0008322ed3
😎 Deploy Preview https://deploy-preview-2372--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

Codecov Report

Merging #2372 (6d8bc4e) into main (187da8a) will decrease coverage by 0.08%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
- Coverage   97.06%   96.98%   -0.08%     
==========================================
  Files         732      732              
  Lines        8826     8834       +8     
  Branches     2181     2131      -50     
==========================================
+ Hits         8567     8568       +1     
- Misses        255      263       +8     
+ Partials        4        3       -1     
Files Coverage Δ
src/sentry.ts 21.05% <10.00%> (-6.23%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187da8a...6d8bc4e. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 2, 2023

Codecov Report

Merging #2372 (6d8bc4e) into main (187da8a) will decrease coverage by 0.08%.
The diff coverage is 10.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
- Coverage   97.06%   96.98%   -0.08%     
==========================================
  Files         732      732              
  Lines        8826     8834       +8     
  Branches     2176     2133      -43     
==========================================
+ Hits         8567     8568       +1     
- Misses        256      263       +7     
  Partials        3        3              
Files Coverage Δ
src/sentry.ts 21.05% <10.00%> (-6.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187da8a...6d8bc4e. Read the comment docs.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2372 (6d8bc4e) into main (187da8a) will decrease coverage by 0.08%.
The diff coverage is 10.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2372     +/-   ##
=======================================
- Coverage   97.07   96.99   -0.08     
=======================================
  Files        732     732             
  Lines       8826    8834      +8     
  Branches    2130    2177     +47     
=======================================
+ Hits        8567    8568      +1     
- Misses       256     262      +6     
- Partials       3       4      +1     
Files Coverage Δ
src/sentry.ts 21.05% <10.00%> (-6.23%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187da8a...6d8bc4e. Read the comment docs.

@nicholas-codecov nicholas-codecov merged commit 581c691 into main Nov 2, 2023
24 of 30 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-add-in-transaction-filter-to-sentry branch November 2, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants