-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Drop Transactions from Blocked User Agents #2372
Conversation
…y in sentry setup
@@ -51,6 +51,14 @@ const deClutterConfig = { | |||
|
|||
export const SentryRoute = Sentry.withSentryRouting(Route) | |||
|
|||
const checkForBlockedUserAgents = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funny! When I first reviewed this I was going to suggest doing an approach like this to add a list of agents we wanted blocked, but then I thought it was a bit overkill, so funny we arrived to this on our own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled it out cause we're using it in two locations now ... so I thought it best they stay in sync with one another
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2372 +/- ##
==========================================
- Coverage 97.06% 96.98% -0.08%
==========================================
Files 732 732
Lines 8826 8834 +8
Branches 2181 2131 -50
==========================================
+ Hits 8567 8568 +1
- Misses 255 263 +8
+ Partials 4 3 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
==========================================
- Coverage 97.06% 96.98% -0.08%
==========================================
Files 732 732
Lines 8826 8834 +8
Branches 2176 2133 -43
==========================================
+ Hits 8567 8568 +1
- Misses 256 263 +7
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2372 +/- ##
=======================================
- Coverage 97.07 96.99 -0.08
=======================================
Files 732 732
Lines 8826 8834 +8
Branches 2130 2177 +47
=======================================
+ Hits 8567 8568 +1
- Misses 256 262 +6
- Partials 3 4 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
Just some small tweaks to our Sentry config to clean up our issues as well as stopping the use of deprecated options.
Notable Changes