627 upgrade page multi choice selector #2376
Conversation
… upgrade plan options
…rade-page-multi-choice-selector
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
- Coverage 96.96% 96.27% -0.70%
==========================================
Files 734 736 +2
Lines 8940 8956 +16
Branches 2221 2229 +8
==========================================
- Hits 8669 8622 -47
- Misses 267 317 +50
- Partials 4 17 +13
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
- Coverage 96.96% 96.27% -0.70%
==========================================
Files 734 736 +2
Lines 8940 8956 +16
Branches 2175 2224 +49
==========================================
- Hits 8669 8622 -47
- Misses 267 318 +51
- Partials 4 16 +12
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
=======================================
- Coverage 96.97 96.27 -0.70
=======================================
Files 734 736 +2
Lines 8940 8956 +16
Branches 2221 2224 +3
=======================================
- Hits 8669 8622 -47
- Misses 266 318 +52
- Partials 5 16 +11
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| ${sentryPlanMonth?.baseUnitPrice} per user / month if paid monthly | ||
| </p> | ||
| {/* TODO: Note that there never was schedules shown here like it is in the pro plan details page. This | ||
| is a bug imo and needs to be here in a future ticket */} |
There was a problem hiding this comment.
Have you created said ticket 👀
There was a problem hiding this comment.
I, have not 😬 will create it now
There was a problem hiding this comment.
| <UpgradeDetails | ||
| accountDetails={accountDetails} | ||
| plan={plan} | ||
| plans={plans} | ||
| proPlanMonth={proPlanMonth} | ||
| proPlanYear={proPlanYear} | ||
| sentryPlanMonth={sentryPlanMonth} | ||
| sentryPlanYear={sentryPlanYear} | ||
| scheduledPhase={scheduledPhase} | ||
| /> | ||
| <UpgradeDetails /> |
There was a problem hiding this comment.
It's so beautiful 🥲
There was a problem hiding this comment.
It truly is, it took a while, but it's worth
Description
We're refactoring the
UpgradeDetailscomponent to better support different plans. This looks like a lot sadly, but it's mostly refactoring tests and putting things into their own folders. This contains no addition of the Team card whatsoever, solely refactoring.Notable Changes
UpgradeDetailsdown to every childUpgradeDetailscomponent without propsSentryPlanDetailscomponent and the newProPlanDetailscomponent. SentryPlanDetails already existed as a subcomponent of the UpgradeDetails file, but I made it into it's own file. ProPlanDetails is a new file that inherited all the logic that used to be in UpgradeDetails. All of these have no props drilled into them.Basic
Basic - sentry user
Pro
Pro - sentry user
Trial
*There's probably functionality improvement (I see someone here using account-details to decide the plan you have, but I decided not to replace that logic with the
usePlanDatahook in case it doesn't work, that comes in later).Screenshots
screen-capture.6.webm
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.