-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Ensure All Queries Use Object Syntax #2389
ref: Ensure All Queries Use Object Syntax #2389
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
- Coverage 96.15% 96.15% -0.01%
==========================================
Files 748 748
Lines 9327 9325 -2
Branches 2332 2288 -44
==========================================
- Hits 8968 8966 -2
- Misses 341 343 +2
+ Partials 18 16 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
- Coverage 96.15% 96.15% -0.01%
==========================================
Files 748 748
Lines 9327 9325 -2
Branches 2332 2332
==========================================
- Hits 8968 8966 -2
Misses 341 341
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2389 +/- ##
=====================================
Coverage 96.15 96.15
=====================================
Files 748 748
Lines 9327 9325 -2
Branches 2319 2332 +13
=====================================
- Hits 8968 8966 -2
- Misses 341 343 +2
+ Partials 18 16 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
params?.search, | ||
params?.isAdmin, | ||
]) | ||
queryClient.invalidateQueries(['SelfHostedUserList']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the whole sets of params to invalidate the query right? Like if you had a query key with
['SelfHostedUserList', 'gh']
['SelfHostedUserList', 'gh', 'codecov']
['SelfHostedUserList']
That prompt will invalidate any of them right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so, they're not 100% explicit, in the docs they say:
The invalidateQueries method can be used to invalidate and refetch single or multiple queries in the cache based on their query keys or any other functionally accessible property/state of the query. By default, all matching queries are immediately marked as invalid and active queries are refetched in the background.
Description
This PR updates a handful of queries to use the object syntax in preparation for the migration to TanStack v5.
Setup work for codecov/engineering-team#678
Notable Changes
MemberTable
and how it invalidates queries