Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Upgrade CTA to Analytics Page #2395

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new CTA on the analytics page for team plan users, urging them to upgrade if they wish to see coverage over time data for private repos.

Closes codecov/engineering-team#773

Notable Changes

  • Add new CTA to ChartSelectors
  • Update tests

Screenshots

Screenshot 2023-11-10 at 7 45 41 AM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit 0e4b548
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/654e6451baf3020007be90ae
😎 Deploy Preview https://deploy-preview-2395--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Nov 10, 2023

Codecov Report

Merging #2395 (0e4b548) into main (e13b331) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2395   +/-   ##
=======================================
  Coverage   96.17%   96.18%           
=======================================
  Files         750      750           
  Lines        9397     9402    +5     
  Branches     2345     2361   +16     
=======================================
+ Hits         9038     9043    +5     
- Misses        341      343    +2     
+ Partials       18       16    -2     
Files Coverage Δ
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13b331...0e4b548. Read the comment docs.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2395 (0e4b548) into main (e13b331) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2395   +/-   ##
=====================================
  Coverage   96.18   96.18           
=====================================
  Files        750     750           
  Lines       9397    9402    +5     
  Branches    2358    2315   -43     
=====================================
+ Hits        9038    9043    +5     
  Misses       343     343           
  Partials      16      16           
Files Coverage Δ
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13b331...0e4b548. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 10, 2023

Codecov Report

Merging #2395 (0e4b548) into main (e13b331) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2395   +/-   ##
=======================================
  Coverage   96.17%   96.18%           
=======================================
  Files         750      750           
  Lines        9397     9402    +5     
  Branches     2314     2348   +34     
=======================================
+ Hits         9038     9043    +5     
+ Misses        343      341    -2     
- Partials       16       18    +2     
Files Coverage Δ
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13b331...0e4b548. Read the comment docs.

{tierData === TierNames.TEAM ? (
<p className="self-end">
Public repos only. <A to={{ pageName: 'upgradeOrgPlan' }}>Upgrade</A>{' '}
to Pro to include private repos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a period at the end here since technically it is a sentence? What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done thanks for the check!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nicholas-codecov nicholas-codecov merged commit 5fa108f into main Nov 10, 2023
@nicholas-codecov nicholas-codecov deleted the gh-eng-773-add-upgrade-cta-to-analytics-page branch November 10, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics page team plan view (with upgrade CTA)
2 participants