-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Upgrade CTA to Analytics Page #2395
feat: Add Upgrade CTA to Analytics Page #2395
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
=======================================
Coverage 96.17% 96.18%
=======================================
Files 750 750
Lines 9397 9402 +5
Branches 2345 2361 +16
=======================================
+ Hits 9038 9043 +5
- Misses 341 343 +2
+ Partials 18 16 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
=====================================
Coverage 96.18 96.18
=====================================
Files 750 750
Lines 9397 9402 +5
Branches 2358 2315 -43
=====================================
+ Hits 9038 9043 +5
Misses 343 343
Partials 16 16
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
=======================================
Coverage 96.17% 96.18%
=======================================
Files 750 750
Lines 9397 9402 +5
Branches 2314 2348 +34
=======================================
+ Hits 9038 9043 +5
+ Misses 343 341 -2
- Partials 16 18 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
{tierData === TierNames.TEAM ? ( | ||
<p className="self-end"> | ||
Public repos only. <A to={{ pageName: 'upgradeOrgPlan' }}>Upgrade</A>{' '} | ||
to Pro to include private repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a period at the end here since technically it is a sentence? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done thanks for the check!
Description
This PR adds in a new CTA on the analytics page for team plan users, urging them to upgrade if they wish to see coverage over time data for private repos.
Closes codecov/engineering-team#773
Notable Changes
ChartSelectors
Screenshots