-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Seats validation for team plan #2397
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2397 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 750 750
Lines 9402 9406 +4
Branches 2366 2318 -48
=======================================
+ Hits 9043 9047 +4
- Misses 341 343 +2
+ Partials 18 16 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 750 750
Lines 9402 9406 +4
Branches 2348 2351 +3
=======================================
+ Hits 9043 9047 +4
Misses 341 341
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2397 +/- ##
=====================================
Coverage 96.18 96.18
=====================================
Files 750 750
Lines 9402 9401 -1
Branches 2317 2361 +44
=====================================
- Hits 9043 9042 -1
Misses 343 343
Partials 16 16
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/shared/utils/upgradeForm.js
Outdated
@@ -87,6 +92,16 @@ export const getSchema = ({ accountDetails, minSeats, trialStatus }) => | |||
message: `You cannot purchase a per user plan for less than ${minSeats} users`, | |||
}) | |||
.transform((val, ctx) => { | |||
if ( | |||
selectedPlan?.value === Plans.USERS_TEAMY && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the monthly plan TEAMM
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh shiii thanks
Description
Add validation logic when person is trying add seats when going for team plan where it can't exceed 10 seats
Notable Changes
Alter schema to handle the seats validation for the team plan
Screenshots
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.