chore: Remove bundle analysis flags #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 855 852 -3
Lines 12112 12041 -71
Branches 3171 3143 -28
==========================================
- Hits 11923 11852 -71
Misses 185 185
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
=======================================
- Coverage 98.44 98.43 -0.01
=======================================
Files 855 852 -3
Lines 12112 12041 -71
Branches 3188 3107 -81
=======================================
- Hits 11923 11852 -71
Misses 185 185
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 855 852 -3
Lines 12112 12041 -71
Branches 3171 3164 -7
==========================================
- Hits 11923 11852 -71
Misses 185 185
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
nicholas-codecov
force-pushed
the
gh-eng-999-and-1214-remove-bundle-analysis-flags
branch
from
9e7e860 to
b31e317
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2693 +/- ##
==========================================
- Coverage 98.43% 98.43% -0.01%
==========================================
Files 855 852 -3
Lines 12112 12041 -71
Branches 3135 3107 -28
==========================================
- Hits 11923 11852 -71
Misses 185 185
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 7.18kB ⬇️
|
Bundle ReportChanges will decrease total bundle size by 7.18kB ⬇️
|
nicholas-codecov
deleted the
gh-eng-999-and-1214-remove-bundle-analysis-flags
branch
RulaKhaled
pushed a commit
that referenced
this pull request
Apr 2, 2024
Remove bundle analysis feature flags from Gazebo. GH codecov/engineering-team#999 GH codecov/engineering-team#1214
RulaKhaled
added a commit
that referenced
this pull request
Apr 3, 2024
* feat: Create useRepoComponents hook * We need branch not term * fix: Handle guest feature error, no nested catch (#2709) * fix: Handle guest feature error, no nested catch * Update tests to reflect graphql error * Fix when to raise an error * my bad bro * Update to re add catch block * build: grab github sha from env (#2672) Update Sentry deps and bundler plugin config to prepare for incoming fix to source map uploading. * ref: Convert file entry stuff to ts (#2698) Part of codecov/engineering-team#588 * chore: Remove bundle analysis flags (#2693) Remove bundle analysis feature flags from Gazebo. GH codecov/engineering-team#999 GH codecov/engineering-team#1214 * Prepare release 24.4.1 (#2737) * Update to use react props with children --------- Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Spencer Murray <159931558+spalmurray-codecov@users.noreply.github.com> Co-authored-by: Codecov Releaser <devops+releaser@codecov.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR goes through and cleans up the flags used for bundle analysis, as well as cleaning up some components that are no longer used.
Closes codecov/engineering-team#999
Closes codecov/engineering-team#1214
Notable Changes
bundleAnalysisPRAndCommitPagesflagnewBundleTabflag