ref: Migrate useOktaConfig to TSQ V5 #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +321,7 @@ describe('OktaConfigForm', () => { | |||
| name: /Okta Login Enforced/, | |||
| }) | |||
| await waitFor(() => { | |||
| expect(oktaLoginEnforceToggle).toHaveClass('bg-toggle-inactive') | |||
| expect(oktaLoginEnforceToggle).toHaveClass('bg-toggle-active') | |||
There was a problem hiding this comment.
I had to update these tests, because beforehand they weren't using the data from the API query, as suspense wasn't enabled on the queryClient, with it being controlled with which query hook you use now (i.e. useSuspenseQuery), these tests started failing, as in prod they would have suspended and used the values from the API.
Bundle ReportChanges will increase total bundle size by 19 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 19 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3683 +/- ##
==========================================
- Coverage 98.83% 98.82% -0.01%
==========================================
Files 825 825
Lines 14886 14889 +3
Branches 4237 4237
==========================================
+ Hits 14712 14714 +2
- Misses 165 166 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3683 +/- ##
==========================================
- Coverage 98.83% 98.82% -0.01%
==========================================
Files 825 825
Lines 14886 14889 +3
Branches 4237 4237
==========================================
+ Hits 14712 14714 +2
- Misses 165 166 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3683 +/- ##
==========================================
- Coverage 98.83% 98.82% -0.01%
==========================================
Files 825 825
Lines 14886 14889 +3
Branches 4229 4229
==========================================
+ Hits 14712 14714 +2
- Misses 165 166 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3683 +/- ##
==========================================
- Coverage 98.83% 98.82% -0.01%
==========================================
Files 825 825
Lines 14886 14889 +3
Branches 4237 4229 -8
==========================================
+ Hits 14712 14714 +2
- Misses 165 166 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
spalmurray-codecov
approved these changes
Jan 28, 2025
nicholas-codecov
deleted the
gh-eng-2963-migrate-useOktaConfig-to-tsq-v5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
useOktaConfigto TSQ V5queryOptionsAPI versionOktaConfigQueryOpts, as well as it's usage in a couple of components and tests.Ticket: codecov/engineering-team#2963
Notable Changes
useOktaConfigtoOktaConfigQueryOptsuseUpdateOktaConfigto use TSQ V5 andOktaConfigQueryOptsto clear the cacheOktaConfigForm, andOktaBannersOktaAccess