-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Onboarding continue button on Safari #3699
Conversation
Bundle ReportChanges will increase total bundle size by 2 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 2 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3699 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14876 +1
Branches 4222 4230 +8
=======================================
+ Hits 14690 14691 +1
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3699 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14876 +1
Branches 4230 4230
=======================================
+ Hits 14690 14691 +1
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3699 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14876 +1
Branches 4230 4222 -8
=======================================
+ Hits 14690 14691 +1
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3699 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14876 +1
Branches 4222 4222
=======================================
+ Hits 14690 14691 +1
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes Safari only race condition in new onboarding flow.