feat: Hide BA trend chart if Timescale is disabled #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 56 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 56 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3708 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14889 -2
Branches 4229 4228 -1
==========================================
Hits 14700 14700
+ Misses 182 180 -2
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3708 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14889 -2
Branches 4237 4236 -1
==========================================
Hits 14700 14700
+ Misses 182 180 -2
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3708 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14889 -2
Branches 4229 4236 +7
==========================================
Hits 14700 14700
+ Misses 182 180 -2
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3708 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 828 828
Lines 14891 14889 -2
Branches 4237 4228 -9
==========================================
Hits 14700 14700
+ Misses 182 180 -2
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
ajay-sentry
reviewed
Feb 4, 2025
| @@ -67,13 +92,13 @@ const BundleContent: React.FC = () => { | |||
| '/:provider/:owner/:repo/bundles/', | |||
| ]} | |||
| > | |||
| <InfoBanner branch={branch} bundle={bundle} /> | |||
| <InfoBanner branch={branchParam} bundle={bundle} /> | |||
There was a problem hiding this comment.
jw, why are these branchParam vs. branch?
There was a problem hiding this comment.
This was done to maintain the current implementation, but I've updated it to work across the board now.
ajay-sentry
approved these changes
Feb 4, 2025
|
@codecov-ai-reviewer review |
nicholas-codecov
deleted the
gh-eng-3215-feat-hide-ba-chart-if-timescale-is-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the bundles tab to conditionally render the trend chart if timescale is not enabled on the backend as the chart is powered from data that comes from timescale.
Closes: codecov/engineering-team#3215
Notable Changes
BranchBundleSummaryQueryOptsfully to query options API and removeuseBranchBundleSummaryBundleContentto conditionallyScreenshots
Timescale enabled:
Timescale disabled: