rename cache _log_hits log args to avoid reserved names #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
requested review from
dana-yaish,
giovanni-guidini and
joseph-sentry
giovanni-guidini
previously approved these changes
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 90 90
Lines 8076 8076
Branches 1228 1228
=======================================
Hits 7372 7372
Misses 701 701
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverted a deploy of
workeras it updatedsharedand hit this bug. this code is covered by tests, but they mock the log entrypoint so it isn't actually going through the standard library logging module in the testline that gets angry:
https://github.com/python/cpython/blob/b831129123dbb4bfba49824ae893448b05398f27/Lib/logging/__init__.py#L1546-L1550
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.