feat: add collection of failure messages in Testruns #4
Conversation
src/junit.rs
Outdated
| @@ -45,6 +45,7 @@ fn populate(attr_hm: &HashMap<String, String>, testsuite: String) -> Result<Test | |||
| duration, | |||
| outcome: Outcome::Pass, | |||
| testsuite, | |||
| failure_message: s(""), | |||
There was a problem hiding this comment.
i think instead failure_message should be Option<String> and it should be set to None here
src/junit.rs
Outdated
| @@ -45,6 +45,7 @@ fn populate(attr_hm: &HashMap<String, String>, testsuite: String) -> Result<Test | |||
| duration, | |||
| outcome: Outcome::Pass, | |||
| testsuite, | |||
| failure_message: s(""), | |||
There was a problem hiding this comment.
i think instead failure_message should be Option<String> and it should be set to None here
| @@ -124,7 +125,18 @@ pub fn parse_junit_xml(file_bytes: Vec<u8>) -> PyResult<Vec<Testrun>> { | |||
| } | |||
| _ => (), | |||
| }, | |||
| Ok(Event::Text(_)) => (), | |||
| Ok(Event::Text(x)) => { | |||
There was a problem hiding this comment.
will this always be a failure message? can we check anything about the context to make sure this is inside of a failure node?
There was a problem hiding this comment.
I've only seen examples of text being a failure message, but I'm not certain, so we could keep track of what kind of event this testcase contains (if it contains any kind of event)
src/junit.rs
Outdated
| xml_failure_message.inplace_trim_end(); | ||
| xml_failure_message.inplace_trim_start(); | ||
|
|
||
| testrun.failure_message = String::from_utf8(xml_failure_message.as_ref().to_vec())?; |
There was a problem hiding this comment.
i think you can do String::from_utf8(xml_failure_message.as_bytes()) and skip creating a vec?
There was a problem hiding this comment.
as_bytes does not seem to exist as a method on BytesText
| @@ -20,6 +31,7 @@ struct PytestLine { | |||
| location: Option<Location>, | |||
| when: String, | |||
| outcome: String, | |||
| longrepr: Option<LongRepr>, | |||
There was a problem hiding this comment.
two things, which you can do in different PRs if you want:
- can you please add doc comments (
///) explaining what the structs/fields all are? no idea whatReprCrashandLongReprare, no idea what values i can expect inwhen,outcome,report_type, not sure whatstart/stopare (probably timestamps...?) when,outcome,report_typeshould probably be enums instead of strings. you can get serde to work with enums
- Make Testrun.failure_message Option type - Use enums in Pytest-reportlog parser for when, outcome and report_type - Check if in failure when handling text node in JUnit parser
No description provided.