Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test results finisher #234

Merged
merged 8 commits into from
Feb 1, 2024

fix: address feedback

5d625ed
Select commit
Loading
Failed to load commit list.
Merged

Add test results finisher #234

fix: address feedback
5d625ed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 1, 2024 in 1s

98.07% (-0.01%) compared to c8afa70

View this Pull Request on Codecov

98.07% (-0.01%) compared to c8afa70

Details

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c8afa70) 98.07% compared to head (5d625ed) 98.07%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   98.07%   98.07%   -0.01%     
==========================================
  Files         406      408       +2     
  Lines       31714    32129     +415     
==========================================
+ Hits        31105    31512     +407     
- Misses        609      617       +8     
Components Coverage Δ
NonTestCode 96.06% <92.56%> (-0.03%) ⬇️
OutsideTasks 97.91% <90.62%> (-0.02%) ⬇️
Files Coverage Δ
services/lock_manager.py 91.48% <100.00%> (+2.35%) ⬆️
tasks/tests/unit/test_notify_task.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_test_results_finisher.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.51% <100.00%> (+<0.01%) ⬆️
tasks/upload.py Critical 97.98% <100.00%> (+<0.01%) ⬆️
tasks/notify.py Critical 97.95% <90.00%> (-0.46%) ⬇️
tasks/test_results_finisher.py 95.45% <95.45%> (ø)
services/test_results.py 86.53% <90.47%> (+5.14%) ⬆️
Related Entrypoints
run/app.tasks.notify.Notify