feat: add task gh_app_name override for more tasks #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33732 33758 +26
=======================================
+ Hits 32836 32862 +26
Misses 896 896
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33732 33758 +26
=======================================
+ Hits 32836 32862 +26
Misses 896 896
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 430 430
Lines 34423 34449 +26
=======================================
+ Hits 33518 33544 +26
Misses 905 905
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This adds ability for more tasks to use the existing configuration options and provide overrides for the GitHubAppInstallation name to be used for a given user. Some of these usages have to be propagated through the task, as is the case with ComputeComparison, for example. :warning: These are not all instances, but most of them. Still working on others.
giovanni-guidini
force-pushed
the
gio/more-tasks-with-dedicated-apps
branch
from
5b1ca4c
to
3e67a19
Compare
This is actually only relevant when we are creating a new report, with carryforward. So should affect mostly `Upload` and `PreProcessUpload` tasks. In any case I've added to some tasks that make intense use of reports.
giovanni-guidini
force-pushed
the
gio/more-tasks-with-dedicated-apps
branch
from
2d1125e
to
cc255a5
Compare
trent-codecov
approved these changes
May 7, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ability for more tasks to use the existing configuration options and
provide overrides for the GitHubAppInstallation name to be used for a given user.
Some of these usages have to be propagated through the task, as is the case with
ComputeComparison, for example.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.