Increase the number of decimal places for the AbstractLevelTotals #458
Conversation
michelletran-codecov
force-pushed
the
increase_report_decimal_places
branch
from
fd7f69a
to
11b1513
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 407 407
Lines 33834 33834
=======================================
Hits 32936 32936
Misses 898 898
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 407 407
Lines 33834 33834
=======================================
Hits 32936 32936
Misses 898 898
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 439 439
Lines 34589 34589
=======================================
Hits 33682 33682
Misses 907 907
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 407 407
Lines 33834 33834
=======================================
Hits 32936 32936
Misses 898 898
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michelletran-codecov
force-pushed
the
increase_report_decimal_places
branch
from
11b1513
to
ce84c8c
Compare
There was a problem hiding this comment.
Lgtm! Just in case, this should be merged after the migrations from this https://github.com/codecov/shared/pull/224/files are applied 👌
michelletran-codecov
force-pushed
the
increase_report_decimal_places
branch
from
f961340
to
ba6db28
Compare
After the migration to increase the number of decimal places for these tables, we should be able to use them to 5 decimal places. We just need to also update the models used in worker for consistency.
This keeps the models in sync. Both the Django and SQLAlchemy models should use the same decimal precisions
michelletran-codecov
force-pushed
the
increase_report_decimal_places
branch
from
ba6db28
to
40b48c2
Compare
After the migration to increase the number of decimal places for these tables, we should be able to use them to 5 decimal places. We just need to also update the models used in worker for consistency.
Migration happens in
shared: codecov/shared#224ref: codecov/engineering-team#1614
Diff for the
sharedupdate: codecov/shared@codecov:f6c2c3852530192ab0c6b9fd0c0a800c2cbdb16f^^^^^...codecov:ae6e12f3cf43188a6d6fa0156ccb78252d3405a8Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.