-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
denoise an obnoxious log #477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 411
Lines 34152 34153 +1
=======================================
+ Hits 33217 33218 +1
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 411
Lines 34152 34153 +1
=======================================
+ Hits 33217 33218 +1
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 411
Lines 34152 34153 +1
=======================================
+ Hits 33217 33218 +1
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 442 442
Lines 34881 34882 +1
=======================================
+ Hits 33937 33938 +1
Misses 944 944
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
@matt-codecov I think I would have preferred closer to 100 lines. Particularly in the case of needing to see if there are multiple directories in the |
instead of logging the full set of path fixes, log the "first" 10, and skip logging a full table of contents ("toc")
the
fixes
andtoc
keys in this log can potentially have an item for every file in the repository. GCP collapses big logs into a smaller row that you can click to expand, but apparently a log can be so big that it will actually be split across several rows, and in at least one case the log was so big that it took up screenful after screenful and made investigating the issue i was working on much harder