feat: horizontally stack test results message #504
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 417 417
Lines 34795 34788 -7
=======================================
- Hits 33912 33906 -6
+ Misses 883 882 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 417 417
Lines 34795 34788 -7
=======================================
- Hits 33912 33906 -6
+ Misses 883 882 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 417 417
Lines 34795 34788 -7
=======================================
- Hits 33912 33906 -6
+ Misses 883 882 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 448 448
Lines 35524 35517 -7
=======================================
- Hits 34631 34625 -6
+ Misses 893 892 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
services/test_results.py
Outdated
| f"**Envs:**<br>{env_section}<br>" | ||
| "</pre>" | ||
| ) | ||
| if "\x1f" in fail.testname: |
There was a problem hiding this comment.
[nit] I'd suggest a little refactor (assuming there's only 1 "\x1f" in the testname)
has_class_name = "\x1f" in fail.testname
if has_class_name:
class_name, test_name = fail.testname.split("\x1f")
test_description = f"- **Class name:** {class_name}<br>**Test name:** {test_name}"
else:
test_description = f"- **Test name:** {fail.testname}"
services/test_results.py
Outdated
| else: | ||
| fail_dict[fail.testsuite].append(fail) | ||
|
|
||
| def process_dict(d): |
There was a problem hiding this comment.
Can this be made a helper function somewhere? It's hard to read functions within functions (even if it makes sense to be here and will never be reused)
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
joseph-sentry
force-pushed
the
joseph/horizontal-stack
branch
from
8d500b0
to
43b6658
Compare
Fixes: codecov/engineering-team#1233