Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add report file name to logs #510

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix: add report file name to logs #510

merged 2 commits into from
Jun 27, 2024

Conversation

joseph-sentry
Copy link
Contributor

@codecov-notifications
Copy link

codecov-notifications bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         417      417           
  Lines       34828    34842   +14     
=======================================
+ Hits        33948    33962   +14     
  Misses        880      880
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/exceptions.py 100.00% <100.00%> (ø)
services/report/__init__.py 92.29% <100.00%> (ø)
services/report/raw_upload_processor.py 93.62% <100.00%> (+0.12%) ⬆️
services/report/tests/unit/test_process.py 99.07% <100.00%> (+0.02%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (359b172) to head (753149c).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         417      417           
  Lines       34828    34842   +14     
=======================================
+ Hits        33948    33962   +14     
  Misses        880      880
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/exceptions.py 100.00% <100.00%> (ø)
services/report/__init__.py 92.29% <100.00%> (ø)
services/report/raw_upload_processor.py 93.62% <100.00%> (+0.12%) ⬆️
services/report/tests/unit/test_process.py 99.07% <100.00%> (+0.02%) ⬆️

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (359b172) to head (753149c).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         417      417           
  Lines       34828    34842   +14     
=======================================
+ Hits        33948    33962   +14     
  Misses        880      880
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/exceptions.py 100.00% <100.00%> (ø)
services/report/__init__.py 92.29% <100.00%> (ø)
services/report/raw_upload_processor.py 93.62% <100.00%> (+0.12%) ⬆️
services/report/tests/unit/test_process.py 99.07% <100.00%> (+0.02%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (359b172) to head (753149c).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         448      448           
  Lines       35557    35571   +14     
=======================================
+ Hits        34667    34681   +14     
  Misses        890      890
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.56% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/exceptions.py 100.00% <100.00%> (ø)
services/report/__init__.py Critical 92.30% <100.00%> (ø)
services/report/raw_upload_processor.py 93.62% <100.00%> (+0.12%) ⬆️
services/report/tests/unit/test_process.py 99.07% <100.00%> (+0.02%) ⬆️

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry requested a review from a team June 26, 2024 14:39
adrian-codecov
adrian-codecov reviewed Jun 26, 2024
View reviewed changes
services/report/raw_upload_processor.py
report=report_file, report_builder=report_builder_to_use
)
except ReportExpiredException as r:
r.filename = current_filename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test uncovered in case we want to make a test for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@joseph-sentry joseph-sentry force-pushed the joseph/add-report-filename branch from 0c559ed to 753149c Compare June 26, 2024 18:41
@joseph-sentry joseph-sentry added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit a3ec32c Jun 27, 2024
29 of 30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-report-filename branch June 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add report filename and path to expired logs
2 participants
@joseph-sentry @adrian-codecov