Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test results flow success event #513

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Jun 21, 2024

I also had to fix some random linting errors so pre commit would pass

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@codecov-notifications
Copy link

codecov-notifications bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   97.46%   97.47%           
=======================================
  Files         417      417           
  Lines       34816    34820    +4     
=======================================
+ Hits        33935    33940    +5     
+ Misses        881      880    -1     
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (ø)
Files Coverage Δ
helpers/checkpoint_logger/flows.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
...s/notification/notifiers/mixins/message/helpers.py 93.15% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.50% <100.00%> (+<0.01%) ⬆️
tasks/upload.py 91.40% <100.00%> (+0.33%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (099e190) to head (9ec4b5d).

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   97.46%   97.47%           
=======================================
  Files         417      417           
  Lines       34816    34820    +4     
=======================================
+ Hits        33935    33940    +5     
+ Misses        881      880    -1     
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (ø)
Files Coverage Δ
helpers/checkpoint_logger/flows.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
...s/notification/notifiers/mixins/message/helpers.py 93.15% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.50% <100.00%> (+<0.01%) ⬆️
tasks/upload.py 91.40% <100.00%> (+0.33%) ⬆️

Copy link

codecov-public-qa bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (099e190) to head (9ec4b5d).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   97.46%   97.47%           
=======================================
  Files         417      417           
  Lines       34816    34820    +4     
=======================================
+ Hits        33935    33940    +5     
+ Misses        881      880    -1     
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (ø)
Files Coverage Δ
helpers/checkpoint_logger/flows.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
...s/notification/notifiers/mixins/message/helpers.py 93.15% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.50% <100.00%> (+<0.01%) ⬆️
tasks/upload.py 91.40% <100.00%> (+0.33%) ⬆️

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (099e190) to head (9ec4b5d).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         448      448           
  Lines       35545    35549    +4     
=======================================
+ Hits        34654    34659    +5     
+ Misses        891      890    -1     
Flag Coverage Δ
integration 97.47% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.47% <100.00%> (+<0.01%) ⬆️
unit 97.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.56% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.74% <100.00%> (ø)
Files Coverage Δ
helpers/checkpoint_logger/flows.py 100.00% <100.00%> (ø)
.../notification/notifiers/mixins/message/__init__.py 100.00% <100.00%> (ø)
...s/notification/notifiers/mixins/message/helpers.py 93.15% <100.00%> (ø)
tasks/tests/unit/test_upload_task.py 99.50% <100.00%> (+<0.01%) ⬆️
tasks/upload.py Critical 91.45% <100.00%> (+0.33%) ⬆️

This change has been scanned for critical changes. Learn more

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@joseph-sentry joseph-sentry requested a review from a team June 21, 2024 14:01
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
@joseph-sentry joseph-sentry added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit bafde3e Jun 21, 2024
29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-test-results-flow branch June 21, 2024 14:30
rohitvinnakota-codecov pushed a commit that referenced this pull request Jun 24, 2024
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants