Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment for disabled CARRYFORWARD_BASE_SEARCH_RANGE experiment #522

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Jun 25, 2024

as the comment says, the results of this experiment (see them here) went back and forth on whether it did anything. there's no particular urgency behind rolling this out anymore, so i'm shutting off the experiment

i'm leaving the Feature here as a knob to turn if we get a support request about missing CFFs / maybe it will spark somebody in the future to retry the experiment for more conclusive results

https://github.com/codecov/internal-issues/issues/405

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

as the comment says, the results of this experiment (see them [here](https://l.codecov.dev/DPGxQO)) went back and forth on whether it did anything. there's no particular urgency behind rolling this out anymore, so i'm shutting off the experiment

i'm leaving the `Feature` here as a knob to turn if we get a support request about missing CFFs / maybe it will spark somebody in the future to retry the experiment for more conclusive results
@matt-codecov matt-codecov requested a review from a team June 25, 2024 22:25
@codecov-notifications
Copy link

codecov-notifications bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         417      417           
  Lines       34828    34828           
=======================================
  Hits        33948    33948           
  Misses        880      880           
Flag Coverage Δ
integration 97.47% <ø> (ø)
latest-uploader-overall 97.47% <ø> (ø)
unit 97.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
services/report/__init__.py 92.29% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (a066a23) to head (d056274).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         417      417           
  Lines       34828    34828           
=======================================
  Hits        33948    33948           
  Misses        880      880           
Flag Coverage Δ
integration 97.47% <ø> (ø)
latest-uploader-overall 97.47% <ø> (ø)
unit 97.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
services/report/__init__.py 92.29% <ø> (ø)

Copy link

codecov-public-qa bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (a066a23) to head (d056274).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         417      417           
  Lines       34828    34828           
=======================================
  Hits        33948    33948           
  Misses        880      880           
Flag Coverage Δ
integration 97.47% <ø> (ø)
latest-uploader-overall 97.47% <ø> (ø)
unit 97.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.51% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
services/report/__init__.py 92.29% <ø> (ø)

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (a066a23) to head (d056274).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         448      448           
  Lines       35557    35557           
=======================================
  Hits        34667    34667           
  Misses        890      890           
Flag Coverage Δ
integration 97.47% <ø> (ø)
latest-uploader-overall 97.47% <ø> (ø)
unit 97.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.56% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
services/report/__init__.py Critical 92.30% <ø> (ø)

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov enabled auto-merge June 26, 2024 15:56
@matt-codecov matt-codecov added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 359b172 Jun 26, 2024
29 of 30 checks passed
@matt-codecov matt-codecov deleted the matt/disable-cf-search-range-expt branch June 26, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants