fix: rewrite raw uploads empty and expired #523
Conversation
The re-write on readable format is currently not working for expired or empty reports. This is because we don't returned the raw report (that despite the name does have a little but of processing to it) in the case that the report is empty or expired. By passing the raw_parsed_report we should start rewriting them in the readable format. This didn't fall in the "rewrite in error" cathegory because these scenarios are not treated as errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 448 448
Lines 35557 35557
=======================================
Hits 34667 34667
Misses 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 417 417
Lines 34828 34828
=======================================
Hits 33948 33948
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 417 417
Lines 34828 34828
=======================================
Hits 33948 33948
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 417 417
Lines 34828 34828
=======================================
Hits 33948 33948
Misses 880 880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The re-write on readable format is currently not working for expired or empty reports.
This is because we don't returned the raw report (that despite the name does have a little
but of processing to it) in the case that the report is empty or expired.
By passing the raw_parsed_report we should start rewriting them in the readable format.
This didn't fall in the "rewrite in error" cathegory because these scenarios are not
treated as errors.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.