Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable sentry profiling #536

Merged
merged 3 commits into from
Jul 2, 2024
Merged

enable sentry profiling #536

merged 3 commits into from
Jul 2, 2024

Conversation

matt-codecov
Copy link
Contributor

we already have sample rates set for sentry overall + for traces. this PR also sets one for profiling

note: the way the traces/profiles sample rate env vars are named follows how shared.config will read configs from env vars, but neither of them is actually part of the installation yaml schema in shared.validation

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

we already have sample rates set for sentry overall + for traces. this PR also sets one for profiling

note: the way the traces/profiles sample rate env vars are named follows how `shared.config` will read configs from env vars, but neither of them is actually part of the installation yaml schema in `shared.validation`
@matt-codecov matt-codecov requested a review from rfox-codecov July 2, 2024 17:52
@codecov-staging
Copy link

codecov-staging bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         418      418           
  Lines       35016    35016           
=======================================
  Hits        34135    34135           
  Misses        881      881           
Flag Coverage Δ
integration 97.48% <ø> (ø)
latest-uploader-overall 97.48% <ø> (ø)
unit 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
helpers/sentry.py 75.00% <ø> (ø)
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (c3bcddf) to head (6967f54).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         449      449           
  Lines       35739    35739           
=======================================
  Hits        34848    34848           
  Misses        891      891           
Flag Coverage Δ
integration 97.48% <ø> (ø)
latest-uploader-overall 97.48% <ø> (ø)
unit 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
helpers/sentry.py 75.00% <ø> (ø)
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)

This change has been scanned for critical changes. Learn more

@codecov-qa
Copy link

codecov-qa bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (c3bcddf) to head (6967f54).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         418      418           
  Lines       35016    35016           
=======================================
  Hits        34135    34135           
  Misses        881      881           
Flag Coverage Δ
integration 97.48% <ø> (ø)
latest-uploader-overall 97.48% <ø> (ø)
unit 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
helpers/sentry.py 75.00% <ø> (ø)
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)

Copy link

codecov-public-qa bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (c3bcddf) to head (6967f54).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         418      418           
  Lines       35016    35016           
=======================================
  Hits        34135    34135           
  Misses        881      881           
Flag Coverage Δ
integration 97.48% <ø> (ø)
latest-uploader-overall 97.48% <ø> (ø)
unit 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.53% <ø> (ø)
OutsideTasks 97.74% <ø> (ø)
Files Coverage Δ
helpers/sentry.py 75.00% <ø> (ø)
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)

@matt-codecov matt-codecov enabled auto-merge July 2, 2024 18:38
@matt-codecov matt-codecov added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 6748d08 Jul 2, 2024
28 of 29 checks passed
@matt-codecov matt-codecov deleted the matt/enable-sentry-profiling branch July 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants