-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable sentry profiling #536
Conversation
we already have sample rates set for sentry overall + for traces. this PR also sets one for profiling note: the way the traces/profiles sample rate env vars are named follows how `shared.config` will read configs from env vars, but neither of them is actually part of the installation yaml schema in `shared.validation`
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 418 418
Lines 35016 35016
=======================================
Hits 34135 34135
Misses 881 881
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 449 449
Lines 35739 35739
=======================================
Hits 34848 34848
Misses 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 418 418
Lines 35016 35016
=======================================
Hits 34135 34135
Misses 881 881
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 418 418
Lines 35016 35016
=======================================
Hits 34135 34135
Misses 881 881
Flags with carried forward coverage won't be shown. Click here to find out more.
|
we already have sample rates set for sentry overall + for traces. this PR also sets one for profiling
note: the way the traces/profiles sample rate env vars are named follows how
shared.config
will read configs from env vars, but neither of them is actually part of the installation yaml schema inshared.validation
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.