Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add report parser metrics #559

Merged
merged 2 commits into from
Jul 18, 2024
Merged

feat: add report parser metrics #559

merged 2 commits into from
Jul 18, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team July 15, 2024 19:11
@codecov-notifications
Copy link

codecov-notifications bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         423      423           
  Lines       35417    35419    +2     
=======================================
+ Hits        34537    34539    +2     
  Misses        880      880
Flag Coverage Δ
integration 97.51% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.51% <100.00%> (+<0.01%) ⬆️
unit 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.75% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.28% <100.00%> (+0.16%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (e78491c) to head (e027c01).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         423      423           
  Lines       35417    35419    +2     
=======================================
+ Hits        34537    34539    +2     
  Misses        880      880
Flag Coverage Δ
integration 97.51% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.51% <100.00%> (+<0.01%) ⬆️
unit 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.75% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.28% <100.00%> (+0.16%) ⬆️

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (e78491c) to head (e027c01).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         423      423           
  Lines       35417    35419    +2     
=======================================
+ Hits        34537    34539    +2     
  Misses        880      880
Flag Coverage Δ
integration 97.51% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.51% <100.00%> (+<0.01%) ⬆️
unit 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.58% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.75% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.28% <100.00%> (+0.16%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (e78491c) to head (e027c01).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   97.54%   97.55%           
=======================================
  Files         456      456           
  Lines       36489    36491    +2     
=======================================
+ Hits        35595    35597    +2     
  Misses        894      894
Flag Coverage Δ
integration 97.51% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.51% <100.00%> (+<0.01%) ⬆️
unit 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.68% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.75% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/report_processor.py 94.28% <100.00%> (+0.16%) ⬆️

This change has been scanned for critical changes. Learn more

@joseph-sentry joseph-sentry marked this pull request as ready for review July 17, 2024 14:24
@joseph-sentry joseph-sentry added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 52b140c Jul 18, 2024
29 of 30 checks passed
@joseph-sentry joseph-sentry deleted the joseph/report-parser-metrics branch July 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovanni-guidini giovanni-guidini giovanni-guidini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @giovanni-guidini