feat: swap the notification services #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 466 466
Lines 37279 37294 +15
=======================================
+ Hits 36397 36412 +15
Misses 882 882
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36073 36088 +15
=======================================
+ Hits 35205 35220 +15
Misses 868 868
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36073 36088 +15
=======================================
+ Hits 35205 35220 +15
Misses 868 868
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36073 36088 +15
=======================================
+ Hits 35205 35220 +15
Misses 868 868
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/service
branch
3 times, most recently
from
06e6e73 to
91fdbec
Compare
Activates the new notification service for bundle analysis
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/activate
branch
from
f1927f0 to
ab309a6
Compare
Swatinem
reviewed
Aug 9, 2024
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/activate
branch
from
fde9e66 to
a7229cf
Compare
move logic to get success value for bundle_analysis_notify return to the return type and create a proper Enum for the success values
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/activate
branch
from
a7229cf to
31acdba
Compare
Swatinem
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activates the new notification service for bundle analysis