Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log when raw upload contains no uploaded files #597

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

matt-codecov
Copy link
Contributor

looking at the nearby counter metrics in Grafana, the median upload supposedly has no raw report files inside of it. we can search this log in GCS to see specific cases of this to see what's up.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

looking at the nearby counter metrics in Grafana, the median upload supposedly has no raw report files inside of it. we can search this log in GCS to see specific cases of this to see what's up.
@matt-codecov matt-codecov requested a review from a team August 7, 2024 18:28
@matt-codecov matt-codecov enabled auto-merge August 7, 2024 18:29
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         429      429           
  Lines       35948    35951    +3     
=======================================
+ Hits        35076    35079    +3     
  Misses        872      872           
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.72% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/__init__.py 92.35% <100.00%> (+0.05%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (7e334d8) to head (64b877b).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         429      429           
  Lines       35948    35951    +3     
=======================================
+ Hits        35076    35079    +3     
  Misses        872      872           
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.72% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/__init__.py 92.35% <100.00%> (+0.05%) ⬆️

@matt-codecov matt-codecov added this pull request to the merge queue Aug 7, 2024
Copy link

codecov-public-qa bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (7e334d8) to head (64b877b).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         429      429           
  Lines       35948    35951    +3     
=======================================
+ Hits        35076    35079    +3     
  Misses        872      872           
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.72% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/__init__.py 92.35% <100.00%> (+0.05%) ⬆️

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (7e334d8) to head (64b877b).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         464      464           
  Lines       37154    37157    +3     
=======================================
+ Hits        36268    36271    +3     
  Misses        886      886           
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.81% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/__init__.py Critical 92.37% <100.00%> (+0.05%) ⬆️

This change has been scanned for critical changes. Learn more

Merged via the queue into main with commit 1357214 Aug 7, 2024
25 of 26 checks passed
@matt-codecov matt-codecov deleted the matt/log-uploads-without-files branch August 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants