chore: user config in notifications #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36096 36147 +51
=======================================
+ Hits 35229 35279 +50
- Misses 867 868 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36096 36147 +51
=======================================
+ Hits 35229 35279 +50
- Misses 867 868 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36096 36147 +51
=======================================
+ Hits 35229 35279 +50
- Misses 867 868 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 466 466
Lines 37302 37353 +51
=======================================
+ Hits 36421 36471 +50
- Misses 881 882 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
giovanni-guidini
force-pushed
the
gio/refactor/ba-notifier/service
branch
from
06e6e73 to
91fdbec
Compare
giovanni-guidini
force-pushed
the
gio/bs-commit-status/notification-settings
branch
from
7704236 to
7e7277c
Compare
giovanni-guidini
force-pushed
the
gio/bs-commit-status/notification-settings
branch
3 times, most recently
from
895487a to
08cd3d9
Compare
Swatinem
approved these changes
Aug 12, 2024
requirements.in
Outdated
| @@ -1,3 +1,4 @@ | |||
| https://github.com/codecov/shared/archive/1ab8ac9b8875ee2da8b473033772c2377f09bf95.tar.gz#egg=shared | |||
These changes hide away the current_yaml from the Contexts. The original idea was to not expose it, but I didn't do that detail correctly the 1st time. Not it's hidden behind the `user_config` field. Builders still have full access. The `user_config` field parses the config that will be used for commit statuses, and also the config already used for the PR comment required changes. There are 2 similar but different configurations: * `required_changes_threshold` is the threshold to send the comment; * `warning_threshold` is the threshold to fail status checks (emit warning by default)
giovanni-guidini
force-pushed
the
gio/bs-commit-status/notification-settings
branch
from
1946182 to
9611ce2
Compare
giovanni-guidini
deleted the
gio/bs-commit-status/notification-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes hide away the current_yaml from the Contexts.
The original idea was to not expose it, but I didn't do that detail correctly the 1st time.
Now it's hidden behind the
user_configfield. Builders still have full access.The
user_configfield parses the config that will be used for commit statuses,and also the config already used for the PR comment required changes.
Notice that we have 2 seemingly redundant options with
changes_thresholdandrequired_changes_threshold. Still waiting on design to clean that up,but they are technically different things at this time:
required_changes_thresholdis the threshold to send the comment;changes_thresholdis the threshold to fail status checksIf they remain separate one of them will be renamed :E