Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tracing #605

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add more tracing #605

merged 2 commits into from
Aug 13, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Aug 9, 2024

This adds a bit more tracing to Upload related tasks, and task calls, as well as disable spammy signal spans in the automatically enabled Sentry Django integration.

@Swatinem Swatinem requested a review from a team August 9, 2024 12:14
@Swatinem Swatinem self-assigned this Aug 9, 2024
This adds a bit more tracing to Upload related tasks, and task calls, as well as disable spammy signal spans in the automatically enabled Sentry Django integration.
@codecov-qa
Copy link

codecov-qa bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (bc5e098) to head (27993c7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36085   +12     
=======================================
+ Hits        35205    35217   +12     
  Misses        868      868           
Flag Coverage Δ
integration 97.59% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <100.00%> (+<0.01%) ⬆️
unit 97.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.82% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/parallel_upload_processing.py 19.64% <100.00%> (+4.54%) ⬆️
helpers/sentry.py 76.00% <100.00%> (+1.00%) ⬆️
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)
services/report/__init__.py 92.40% <100.00%> (+0.04%) ⬆️
tasks/base.py 96.19% <100.00%> (+0.04%) ⬆️
tasks/upload.py 91.15% <100.00%> (+0.05%) ⬆️
tasks/upload_processor.py 92.57% <100.00%> (+0.03%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36085   +12     
=======================================
+ Hits        35205    35217   +12     
  Misses        868      868           
Flag Coverage Δ
integration 97.59% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <100.00%> (+<0.01%) ⬆️
unit 97.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.82% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/parallel_upload_processing.py 19.64% <100.00%> (+4.54%) ⬆️
helpers/sentry.py 76.00% <100.00%> (+1.00%) ⬆️
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)
services/report/__init__.py 92.40% <100.00%> (+0.04%) ⬆️
tasks/base.py 96.19% <100.00%> (+0.04%) ⬆️
tasks/upload.py 91.15% <100.00%> (+0.05%) ⬆️
tasks/upload_processor.py 92.57% <100.00%> (+0.03%) ⬆️

Copy link

codecov-public-qa bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (bc5e098) to head (27993c7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36085   +12     
=======================================
+ Hits        35205    35217   +12     
  Misses        868      868           
Flag Coverage Δ
integration 97.59% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <100.00%> (+<0.01%) ⬆️
unit 97.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.82% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/parallel_upload_processing.py 19.64% <100.00%> (+4.54%) ⬆️
helpers/sentry.py 76.00% <100.00%> (+1.00%) ⬆️
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)
services/report/__init__.py 92.40% <100.00%> (+0.04%) ⬆️
tasks/base.py 96.19% <100.00%> (+0.04%) ⬆️
tasks/upload.py 91.15% <100.00%> (+0.05%) ⬆️
tasks/upload_processor.py 92.57% <100.00%> (+0.03%) ⬆️

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (bc5e098) to head (27993c7).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         466      466           
  Lines       37279    37291   +12     
=======================================
+ Hits        36397    36409   +12     
  Misses        882      882           
Flag Coverage Δ
integration 97.59% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <100.00%> (+<0.01%) ⬆️
unit 97.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.86% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.82% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
helpers/parallel_upload_processing.py 19.64% <100.00%> (+4.54%) ⬆️
helpers/sentry.py 76.00% <100.00%> (+1.00%) ⬆️
helpers/tests/unit/test_sentry.py 100.00% <ø> (ø)
services/report/__init__.py Critical 92.42% <100.00%> (+0.04%) ⬆️
tasks/base.py Critical 96.19% <100.00%> (+0.04%) ⬆️
tasks/upload.py Critical 91.20% <100.00%> (+0.05%) ⬆️
tasks/upload_processor.py 93.10% <100.00%> (+0.03%) ⬆️

This change has been scanned for critical changes. Learn more

@Swatinem Swatinem added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 5fd5d9b Aug 13, 2024
25 of 26 checks passed
@Swatinem Swatinem deleted the swatinem/more-tracing branch August 13, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants