-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up UploadFinisher
task a bit
#607
Conversation
Fixes a typo, adds a few types and simplifies code slightly
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36073 36069 -4
=======================================
- Hits 35205 35202 -3
+ Misses 868 867 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36073 36069 -4
=======================================
- Hits 35205 35202 -3
+ Misses 868 867 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 431 431
Lines 36073 36069 -4
=======================================
- Hits 35205 35202 -3
+ Misses 868 867 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 466 466
Lines 37279 37275 -4
=======================================
- Hits 36397 36394 -3
+ Misses 882 881 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes a typo, adds a few types and simplifies code slightly
Extracted from #592