Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up UploadFinisher task a bit #607

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

Swatinem
Copy link
Contributor

Fixes a typo, adds a few types and simplifies code slightly


Extracted from #592

Fixes a typo, adds a few types and simplifies code slightly
@Swatinem Swatinem requested a review from a team August 12, 2024 13:38
@Swatinem Swatinem self-assigned this Aug 12, 2024
@codecov-qa
Copy link

codecov-qa bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.59%. Comparing base (c6d3ce2) to head (22d3dff).

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/upload_finisher.py 85.71% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36069    -4     
=======================================
- Hits        35205    35202    -3     
+ Misses        868      867    -1     
Flag Coverage Δ
integration 97.59% <85.71%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <85.71%> (+<0.01%) ⬆️
unit 97.59% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <85.71%> (+<0.01%) ⬆️
OutsideTasks 97.82% <ø> (ø)
Files Coverage Δ
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 73.58% <85.71%> (-0.03%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/upload_finisher.py 85.71% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36069    -4     
=======================================
- Hits        35205    35202    -3     
+ Misses        868      867    -1     
Flag Coverage Δ
integration 97.59% <85.71%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <85.71%> (+<0.01%) ⬆️
unit 97.59% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <85.71%> (+<0.01%) ⬆️
OutsideTasks 97.82% <ø> (ø)
Files Coverage Δ
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 73.58% <85.71%> (-0.03%) ⬇️

Copy link

codecov-public-qa bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.59%. Comparing base (c6d3ce2) to head (22d3dff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36069    -4     
=======================================
- Hits        35205    35202    -3     
+ Misses        868      867    -1     
Flag Coverage Δ
integration 97.59% <85.71%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <85.71%> (+<0.01%) ⬆️
unit 97.59% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <85.71%> (+<0.01%) ⬆️
OutsideTasks 97.82% <ø> (ø)
Files Coverage Δ
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 73.58% <85.71%> (-0.03%) ⬇️

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (c6d3ce2) to head (22d3dff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/upload_finisher.py 85.71% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         466      466           
  Lines       37279    37275    -4     
=======================================
- Hits        36397    36394    -3     
+ Misses        882      881    -1     
Flag Coverage Δ
integration 97.59% <85.71%> (+<0.01%) ⬆️
latest-uploader-overall 97.59% <85.71%> (+<0.01%) ⬆️
unit 97.59% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.86% <85.71%> (+<0.01%) ⬆️
OutsideTasks 97.82% <ø> (ø)
Files Coverage Δ
tasks/tests/unit/test_upload_finisher_task.py 100.00% <ø> (ø)
tasks/upload_finisher.py 73.70% <85.71%> (-0.03%) ⬇️
Related Entrypoints
run/app.tasks.upload.UploadFinisher

@Swatinem Swatinem added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 8fdff97 Aug 13, 2024
23 of 26 checks passed
@Swatinem Swatinem deleted the swatinem/cleanup-uploadfinisher branch August 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants